Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove RM Name from RP descriptions #9758

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Jul 30, 2024

Ticket

Description

Remove the "Resource Manager Name" from the resource pool configuration description since resource managers are now identified and distinguished by their "Cluster Name".
A few more docs changes to replace the terminology "resource manager name" with "resource manager's cluster name"

WebUI Change:

Before
WithRMName

After
NoRMName

Test Plan

CI passes

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@amandavialva01 amandavialva01 requested a review from a team as a code owner July 30, 2024 12:29
@cla-bot cla-bot bot added the cla-signed label Jul 30, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 30, 2024
@determined-ci determined-ci requested a review from a team July 30, 2024 12:29
Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 59fde82
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a8ea162f3238000867d09b

@amandavialva01 amandavialva01 added to-cherry-pick Pull requests that need to be cherry-picked into the current release and removed documentation Improvements or additions to documentation labels Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.11%. Comparing base (fc8ac0b) to head (59fde82).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9758      +/-   ##
==========================================
- Coverage   54.12%   54.11%   -0.01%     
==========================================
  Files        1257     1257              
  Lines      154854   154854              
  Branches     3487     3487              
==========================================
- Hits        83810    83806       -4     
- Misses      70898    70902       +4     
  Partials      146      146              
Flag Coverage Δ
backend 44.87% <ø> (-0.01%) ⬇️
harness 72.62% <ø> (ø)
web 53.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 30, 2024
@determined-ci determined-ci requested a review from a team July 30, 2024 13:19
Copy link
Contributor

@corban-beaird corban-beaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid!

@amandavialva01 amandavialva01 merged commit becd8b6 into main Jul 30, 2024
82 of 96 checks passed
@amandavialva01 amandavialva01 deleted the amanda/removeMoreRMName branch July 30, 2024 13:53
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants